fix potential ReDoS in route annotator regex#325
Merged
Conversation
Add \A anchor to /\s*#/ regex in strip_annotations to avoid unnecessary backtracking on unanchored patterns.
drwl
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
\Aanchor to the/\s*#/regex instrip_annotationsto avoid unnecessary backtracking from an unanchored pattern.Without the anchor, the regex engine attempts a match at every position in the string. For example, given
" x", it tries position 0, then 1, then 2, and so on. Since each line is already split on newlines, anchoring the pattern to the start of the string does not change the match result, but it does eliminate redundant matching attempts.