Skip to content

fix(http): reject ambiguous requests with both CL and TE headers #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
an-tao merged 1 commit into from
Aug 4, 2026
Merged

fix(http): reject ambiguous requests with both CL and TE headers #2550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/src/HttpRequestParser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,16 @@ int HttpRequestParser::parseRequest(MsgBuffer *buf)

// process header information
auto &len = request_->getHeaderBy("content-length");
auto &encode = request_->getHeaderBy("transfer-encoding");
if (!len.empty() && !encode.empty())
{
// RFC 9112 Section 6.3:
// Messages containing both Content-Length and
// Transfer-Encoding are ambiguous and might indicate
// request smuggling. Reject such requests to avoid
// inconsistent message framing.
return -k400BadRequest;
}
if (!len.empty())
{
try
Expand All @@ -246,8 +256,6 @@ int HttpRequestParser::parseRequest(MsgBuffer *buf)
}
else
{
const std::string &encode =
request_->getHeaderBy("transfer-encoding");
if (encode.empty())
{
// no content-length and no transfer-encoding,
Expand Down
Loading