Simplify parseLine() in create_view.cc - #2418
Open
folosuru wants to merge 2 commits into
Open
Conversation
folosuru
commented
Dec 9, 2025
folosuru
commented
- Changed to search for the first tag at line in parseLine()
- Moved to some code to function
folosuru
force-pushed
the
refactor-create-view
branch
2 times, most recently
from
December 10, 2025 12:14
6a8c91e to
a374fed
Compare
folosuru
force-pushed
the
refactor-create-view
branch
from
December 10, 2025 12:45
9eacfa7 to
5ed9d83
Compare
Author
|
I forgot to add ";" at end of line. sorry... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.