Skip to content

Adding Romanian language support#124

Closed
ticlazau wants to merge 4 commits into
drivendataorg:masterfrom
ticlazau:master
Closed

Adding Romanian language support#124
ticlazau wants to merge 4 commits into
drivendataorg:masterfrom
ticlazau:master

Conversation

@ticlazau

@ticlazau ticlazau commented Mar 2, 2021

Copy link
Copy Markdown

No description provided.

ticlazau added 2 commits March 2, 2021 11:44
Adding Romanian language support
Adding Romanian language support
@codecov

codecov Bot commented Mar 2, 2021

Copy link
Copy Markdown

Codecov Report

Merging #124 (92b197d) into master (f5cd730) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files           6        6           
  Lines         188      188           
=======================================
  Hits          182      182           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cd730...46df85a. Read the comment docs.

@pjbull

pjbull commented Mar 4, 2021

Copy link
Copy Markdown
Member

@ticlazau amazing, thanks! Everything is in this PR, and I can close #122 and #123, correct?

Also, can you lowercase RO to ro? I think that's conventional for the ISO 639-1 codes: https://en.wikipedia.org/wiki/ISO_639-1

ticlazau added 2 commits March 5, 2021 13:49
Changing the file name to match the country standard.
…s_ro.yml

Changing the file name to match the country standard.
@ticlazau ticlazau closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants