JIT: forward-sub cheap address temps with multiple uses#129312
Open
AndyAyersMS wants to merge 1 commit into
Open
JIT: forward-sub cheap address temps with multiple uses#129312AndyAyersMS wants to merge 1 commit into
AndyAyersMS wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Member
Author
|
For the canonical repro: struct FooS { public int a, b; }
class StructContainer
{
FooS foo;
public void Update() { foo.a++; foo.b++; }
}x64 codegen (FullOpts), 12 bytes / 4 insns → 6 bytes / 2 insns: ; Before
lea rax, [rcx+0x08]
inc dword ptr [rax]
add rcx, 12
inc dword ptr [rcx]
; After
inc dword ptr [rcx+0x08]
inc dword ptr [rcx+0x0C]Note This comment was authored with the assistance of GitHub Copilot CLI. |
Member
Author
|
@dhartglassMSFT PTAL |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the JIT’s forward-substitution phase to allow substituting certain cheap “address temp” expressions at multiple use sites (not just a single last-use), primarily to unblock downstream address-mode containment in Lowering. It also factors out a common GT_FIELD_ADDR-peeling loop into Compiler::gtPeelFieldAddrs and reuses it from a couple of other call sites.
Changes:
- Add
Compiler::gtPeelFieldAddrsand use it fromimpIsAddressInLocalandfgAddrCouldBeHeap. - Add a multi-use forward-substitution path for “cheap reorderable address trees”, implemented via
fgForwardSubMultiUse. - Update
compiler.hwith new helper/method declarations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/promotiondecomposition.cpp | Adds Compiler::gtPeelFieldAddrs helper implementation. |
| src/coreclr/jit/importer.cpp | Replaces local FIELD_ADDR peeling with gtPeelFieldAddrs. |
| src/coreclr/jit/forwardsub.cpp | Adds cheap-address detection and multi-use forward-substitution logic. |
| src/coreclr/jit/flowgraph.cpp | Reuses gtPeelFieldAddrs in fgAddrCouldBeHeap. |
| src/coreclr/jit/compiler.h | Declares gtPeelFieldAddrs and fgForwardSubMultiUse. |
AndyAyersMS
force-pushed
the
fix-67187-fwdsub
branch
from
4819780 to
eba75bf
Compare
Substitute a FIELD_ADDR chain rooted at a local at every use site so the dup-spill temp for field updates no longer blocks address-mode containment in Lowering. Also refactor the FIELD_ADDR walk into gtPeelFieldAddrs and share it with fgAddrCouldBeHeap and impIsAddressInLocal. The multi-use path pre-allocates every clone before mutating the IR (so a gtCloneExpr failure bails cleanly), caps the use count at four to keep the targeted patterns in scope, and conservatively clears GTF_VAR_DEATH bits on every LCL_VAR in the inserted copies. The peel helper has a const overload so callers like impIsAddressInLocal stay const-safe. Fixes dotnet#67187. > [!NOTE] > This change was authored with the assistance of GitHub Copilot CLI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AndyAyersMS
force-pushed
the
fix-67187-fwdsub
branch
from
eba75bf to
b1a0c81
Compare
Comment on lines
+258
to
+261
| // Rebuild metadata since we changed which LCL_VARs appear in nextStmt. | ||
| fgSequenceLocals(nextStmt); | ||
| gtUpdateStmtSideEffects(nextStmt); | ||
| return true; |
Comment on lines
+183
to
+191
| fgWalkResult PreOrderVisit(GenTree** use, GenTree* user) | ||
| { | ||
| GenTree* node = *use; | ||
| if (node->OperIs(GT_LCL_VAR) && (node->AsLclVarCommon()->GetLclNum() == m_lclNum)) | ||
| { | ||
| m_useSlots.Push(use); | ||
| } | ||
| return fgWalkResult::WALK_CONTINUE; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substitute a FIELD_ADDR chain rooted at a local at every use site so the dup-spill temp for field updates no longer blocks address-mode containment in Lowering. Also refactor the FIELD_ADDR walk into gtPeelFieldAddrs and share it with fgAddrCouldBeHeap and impIsAddressInLocal.
Fixes #67187.
Note
This change was authored with the assistance of GitHub Copilot CLI.