Repository navigation
Fix double return of the TLS handshake's timeout source in TcpServer - #307
Merged
Merged
Conversation
After the TLS handshake the timeout scope was returned to the multiplexer's pool but not reset, so a connection that ended before its first message returned it again in HandleConnection's finally. If the pooled source had been disposed meanwhile (e.g. canceled by another connection's handshake timeout, or on shutdown), TryReset threw ObjectDisposedException from the async void method and the process terminated; otherwise the same source could be handed to two connections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@dotnet-policy-service agree |
ferociousbyte
marked this pull request as draft
October 24, 2026 09:05
ferociousbyte
marked this pull request as ready for review
October 24, 2026 09:05
Collaborator
|
@ferociousbyte , thanks for your contribution! |
sakno
added
the
ai_assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306. After the TLS handshake the timeout scope is reset, so the connection's
finallyno longer returns the same pooledCancellationTokenSourcea second time (which threwObjectDisposedExceptionfromasync voidHandleConnectionon shutdown and could share one source between two connections).Includes a regression test.
This change was made with the help of an AI model (Claude). I can't set labels on this repository; could a maintainer please add
ai_assisted?