[hot reload] implement DeployHotReloadAgentConfiguration target
#10699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/sdk#52492 Context: https://github.com/dotnet/runtime/blob/79609d7dbef01231b0694a356de1d4e5618785cd/src/libraries/System.Private.CoreLib/src/System/StartupHookProvider.cs#L32 Context: https://github.com/dotnet/runtime/blob/79609d7dbef01231b0694a356de1d4e5618785cd/src/mono/mono/metadata/object.c#L8137-L8140 Context: b2332ca Added a new `DeployHotReloadAgentConfiguration` MSBuild target that `dotnet-watch` can use to configure Hot Reload for Android apps. Notes on runtimes: * MonoVM currently passes `string.Empty` to `ProcessStartupHooks` and relies on reading `STARTUP_HOOKS` from `AppContext`. * To fix CoreCLR, we can read `DOTNET_STARTUP_HOOKS` from environment variables, and pass to `ProcessStartupHooks`. * NativeAOT likely works as-is. I added/updated tests to verify these changes.
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/sdk#52492
Context: https://github.com/dotnet/runtime/blob/79609d7dbef01231b0694a356de1d4e5618785cd/src/libraries/System.Private.CoreLib/src/System/StartupHookProvider.cs#L32
Context: https://github.com/dotnet/runtime/blob/79609d7dbef01231b0694a356de1d4e5618785cd/src/mono/mono/metadata/object.c#L8137-L8140
Context: b2332ca
Added a new
DeployHotReloadAgentConfigurationMSBuild target thatdotnet-watchcan use to configure Hot Reload for Android apps.Notes on runtimes:
MonoVM currently passes
string.EmptytoProcessStartupHooksand relies on readingSTARTUP_HOOKSfromAppContext.To fix CoreCLR, we can read
DOTNET_STARTUP_HOOKSfrom environment variables, and pass toProcessStartupHooks.NativeAOT likely works as-is.
I added/updated tests to verify these changes.