Open
Conversation
maycon-mello
force-pushed
the
passkeys-web-wallet
branch
from
732f7d1 to
1628bdc
Compare
maycon-mello
force-pushed
the
passkeys-web-wallet
branch
from
2019024 to
ce8045a
Compare
There was a problem hiding this comment.
Pull request overview
Adds passkey-based authentication to the Truvera Web Wallet SDK, enabling WebAuthn PRF-derived key material to encrypt/decrypt the cloud wallet master key, with automatic enrollment + localStorage persistence on first use.
Changes:
- Introduces low-level WebAuthn passkey helpers (register, PRF assertion, credentialId encoding).
- Extends web
initialize()to supportpasskey: true | { ...options }, including enrollment and subsequent authentication. - Adds core cloud-wallet passkey key-derivation + enrollment/authentication helpers and updates docs/examples/tests.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/src/passkey.js | New WebAuthn/PRF helper utilities (registration, PRF extraction, credentialId encode/decode). |
| packages/web/src/passkey.test.js | Unit tests for passkey helpers. |
| packages/web/src/index.js | Adds passkey flow to SDK initialization, plus exported passkey helpers. |
| packages/web/src/index.test.js | Adds initialization tests for passkey enroll/auth flows and validation changes. |
| packages/web/README.md | Documents passkey auth usage/options and mnemonic return behavior. |
| packages/web/example.html | Updates mnemonic example to use local bundle and logs output. |
| packages/web/example-passkey.html | Adds passkey example HTML page. |
| packages/core/src/cloud-wallet.ts | Adds passkey-based vault key derivation + enroll/auth/init APIs. |
| packages/core/src/cloud-wallet.test.js | Adds tests for new core passkey APIs. |
| docs/cloud-wallet.md | Documents passkey authentication architecture and usage patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nfirmed during ceremony
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| stored = JSON.parse(storedValue); | ||
| } | ||
| } catch { | ||
| // Malformed JSON or localStorage access error |
Contributor
There was a problem hiding this comment.
would the actual error detail be useful for debugging?
| rpId, | ||
| }; | ||
| } catch { | ||
| throw new Error( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.