Support echo "hello" | docker agent | cat#2197
Merged
dgageot merged 2 commits intodocker:mainfrom Mar 20, 2026
Merged
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR successfully implements support for piping input/output through docker-agent. The changes are well-structured:
- TTY Detection: Properly detects TTY status at Printer creation time
- Agent Name Header: Correctly suppressed when output is not a TTY (e.g., piped to
cat) - Stdin Handling: New case handles piped input when stdin is not a terminal
- Test Updates: All tests updated to reflect the new behavior
No bugs found in the changed code. The implementation correctly handles the use case echo "hello" | docker agent | cat.
Skip printing the '--- Agent: root ---' header when output is piped, so that 'echo hello | docker agent | cat' produces clean output. Assisted-By: docker-agent
derekmisler
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.