Fix configsvr with user/pass env vars#600
Open
yosifkit wants to merge 1 commit intodocker-library:masterfrom
Open
Fix configsvr with user/pass env vars#600yosifkit wants to merge 1 commit intodocker-library:masterfrom
yosifkit wants to merge 1 commit intodocker-library:masterfrom
Conversation
tianon
approved these changes
Jan 6, 2023
|
Will this or a similar fix ever be merged? |
Member
|
As noted by @yosifkit in #717 (comment), we're still not sure this is actually a "correct" fix (and frankly the entrypoint scripts here are already doing way more than we're comfortable with maintaining, which is part of why we avoided adding even the basic functionality they currently have for so long). |
|
So … should I assume this will not be fixed for a while? |
Member
Author
I rebased the PR to keep it up to date, but we are still unsure that it is correct. |
|
Thanks! There's probably no way for me to test the docker image without building it myself, is there? In my hosting environment, I can only add a docker image, like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 5.0, setting the
sharding.clusterRole/--configsvrrequires it to be part of a replica set so this fixes part of #509 (for--configsvr). Not certain we need to do anything for--shardsvrsince they shouldn't use the entrypoint user/pass orinitdb.dscripts there.Technically, adding
--auth(via adding user/pass) also requires akeyFilefor areplset, but that is something the user needs to add (not something we can fix in the entrypoint)(I'd recommend users also set
--hostnamewhen using replica sets depending on how they set up members in their replica configurationrs.init(...).)