test_extractor: Allow compile-only unittests for certain version's#438
Draft
MoonlightSentinel wants to merge 1 commit intodlang:masterfrom
Draft
test_extractor: Allow compile-only unittests for certain version's#438MoonlightSentinel wants to merge 1 commit intodlang:masterfrom
MoonlightSentinel wants to merge 1 commit intodlang:masterfrom
Conversation
This enables e.g. verification for tests hidden by `version (StdDoc)`
without running them (wich usually are version'ed for exactly that
reason).
This change wraps the unittest body in `if (false) { ... }` if it's
located within a version passed via `--compileOnlyVersions`.
Contributor
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + tools#438" |
Member
|
Honestly I feel like we are over-engineering this. It would have been simpler to just come up with a different test :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables e.g. verification for tests hidden by
version (StdDoc)without running them (wich usually are version'ed for exactly that
reason).
This change wraps the unittest body in
if (false) { ... }if it'slocated within a version passed via
--compileOnlyVersions.CC @CyberShadow Opted for a different flag because both behaviours have their merit.