Fix kB-to-bytes conversion in Linux smaps parsing - #119
Merged
Conversation
The smaps parser multiplied kB values from /proc/[pid]/smaps by 1000 to convert to bytes, but kB in /proc means kibibytes (1024 bytes). This caused all smaps memory metrics (pss, rss, uss, vss, swap) to be underreported by approximately 2.4%. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Hm, that does seem to be the case. I wonder if it was always so, but whatever, it's kb now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/[pid]/smapsby 1000 to convert to bytes/procmeans kibibytes (1024 bytes), not 1000pss,rss,uss,vss,swap) to be underreported by approximately 2.4%Test plan
bundle exec rake)🤖 Generated with Claude Code