[DAP-18] Replace PartialBatchSelector with aggregation job extensions - #4824
Merged
Conversation
Fixes #4784 Per [DAP PR #762](ietf-wg-ppm/draft-ietf-ppm-dap#762), replaces the `PartialBatchSelector` in `AggregationJobInitializeReq` with an `AggregationJobExtension` list. - New `AggregationJobExtension` + `AggregationJobExtensionType` registry (n.b. `leader_selected_batch_id` = 0x0001). - Leader-selected batch ID now travels as an extension; the message is no longer generic over batch mode. - Helper enforcement: unknown type becomes `unsupportedExtension`; out-of-order or missing/malformed batch-id becomes `invalidMessage`.
jcjones
marked this pull request as ready for review
August 25, 2026 18:32
tgeoghegan
approved these changes
Aug 25, 2026
The helper now rejects a leader_selected_batch_id aggregation job extension on time-interval tasks. Adds a `aggregation_job_init_unexpected_batch_id_extension` test.
divergentdave
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4784
Per DAP PR #762, replaces the
PartialBatchSelectorinAggregationJobInitializeReqwith anAggregationJobExtensionlist.AggregationJobExtension+AggregationJobExtensionTyperegistry (n.b.leader_selected_batch_id= 0x0001).unsupportedExtension; out-of-order or missing/malformed batch-id becomesinvalidMessage.