Store task query type separately - #2552
Open
divergentdave wants to merge 3 commits into
Open
divergentdave wants to merge 3 commits into
divergentdave wants to merge 3 commits into
Conversation
divergentdave
force-pushed
the
david/query-type-migration
branch
from
September 22, 2026 17:06
c8da56f to
eae299b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
divergentdave
force-pushed
the
david/query-type-migration
branch
from
September 22, 2026 17:11
eae299b to
bb034b4
Compare
This was referenced Sep 22, 2026
tgeoghegan
approved these changes
Sep 22, 2026
divergentdave
force-pushed
the
david/query-type-migration
branch
from
September 22, 2026 20:00
bb034b4 to
8f2a4dd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #874. This adds a query type column to the database, and adds query type fields to request and response objects used by divviup-api. I haven't made any changes to the webapp, client library, or CLI thus far. The
NewTaskfield is optional to ensure backwards compatibility, and we backfill the query type based on the existing rule, looking at the presence of a maximum batch size. The database migration similarly backfills the new column with the same logic. I relaxed the types used by the aggregator API client so that newer divviup-api clients have the option to omit a maximum batch size.I did manual testing of the migration on a variety of tasks, and confirmed the backfill query worked correctly. I also tested task creation via the web app after the changes, and that still worked as expected.