Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughBump PyO3 deps to 0.28.2 and switch pyo3-file git source; relax dev Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
pyproject.toml (1)
25-25: Consider adding an upper bound to thepandas[excel]dev constraint.
>=2.2has no ceiling, so a future pandas major release that breaks test helpers could cause silent CI failures. A tighter spec like>=2.2,<4would still cover the intended range while guarding against surprise breakage.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 25, The dev dependency "pandas[excel]>=2.2" has no upper bound; update the pyproject.toml dev dependency to pin an upper limit (for example change "pandas[excel]>=2.2" to "pandas[excel]>=2.2,<4") to prevent accidental breaks from future major pandas releases while still allowing patch/minor upgrades.Cargo.toml (1)
18-18: Pinned to author's ownpyo3-filefork — document the upstream migration plan.Switching from
omerbenamram/pyo3-filetodimastbk/pyo3-fileis a pragmatic workaround while upstream catches up to PyO3 0.28, but the pinned git dependency has a few downsides:
- Automated dependency tools (Renovate, Dependabot) cannot track or bump it.
- Security patches from upstream are not automatically inherited.
Consider opening a tracking issue to flip back to the upstream crate once it gains PyO3 0.28 compatibility.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Cargo.toml` at line 18, The Cargo.toml currently pins a git dependency to dimastbk/pyo3-file (the line with pyo3-file = { git = "...", rev = "b0a5b26..." }) which should be tracked and planned to revert to the upstream omerbenamram/pyo3-file once it supports PyO3 0.28; add a short TODO comment near that dependency in Cargo.toml mentioning the upstream repository and target (omerbenamram/pyo3-file) and reference creating a tracking issue in our repo (open an issue titled e.g. "Revert pyo3-file to upstream when PyO3 0.28 compatible") that lists the current rev and the condition for flipping back, then add the new issue number or link to the Cargo.toml comment so automated tools and future maintainers can find the migration plan.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Cargo.toml`:
- Line 18: The Cargo.toml currently pins a git dependency to dimastbk/pyo3-file
(the line with pyo3-file = { git = "...", rev = "b0a5b26..." }) which should be
tracked and planned to revert to the upstream omerbenamram/pyo3-file once it
supports PyO3 0.28; add a short TODO comment near that dependency in Cargo.toml
mentioning the upstream repository and target (omerbenamram/pyo3-file) and
reference creating a tracking issue in our repo (open an issue titled e.g.
"Revert pyo3-file to upstream when PyO3 0.28 compatible") that lists the current
rev and the condition for flipping back, then add the new issue number or link
to the Cargo.toml comment so automated tools and future maintainers can find the
migration plan.
In `@pyproject.toml`:
- Line 25: The dev dependency "pandas[excel]>=2.2" has no upper bound; update
the pyproject.toml dev dependency to pin an upper limit (for example change
"pandas[excel]>=2.2" to "pandas[excel]>=2.2,<4") to prevent accidental breaks
from future major pandas releases while still allowing patch/minor upgrades.
Summary by CodeRabbit
Chores
Improvements