Skip to content

chore: deprecate getParser method across all parsers format.#176

Merged
sbillinge merged 2 commits intodiffpy:v3.4.0from
stevenhua0320:deprecate-getParser
Mar 6, 2026
Merged

chore: deprecate getParser method across all parsers format.#176
sbillinge merged 2 commits intodiffpy:v3.4.0from
stevenhua0320:deprecate-getParser

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge ready to review.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (70aa675) to head (810ef8a).
⚠️ Report is 4 commits behind head on v3.4.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.4.0     #176   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          14       14           
  Lines        2359     2359           
=======================================
  Hits         2339     2339           
  Misses         20       20           
Files with missing lines Coverage Δ
tests/test_p_cif.py 99.69% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

this got conflicted. It looks similar to the PR I just merged so I am not sure what happened

@stevenhua0320
Copy link
Contributor Author

stevenhua0320 commented Mar 6, 2026

@sbillinge I have reviewed it, it is because of the incoming toLines setting message for deprecation in P_discus.py, I accepted the change there and it is ready to merge.

@sbillinge sbillinge merged commit 5ddd7b4 into diffpy:v3.4.0 Mar 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants