fix(app): show a check icon for completed workspace-creation steps#2609
Open
magic-peach wants to merge 1 commit into
Open
fix(app): show a check icon for completed workspace-creation steps#2609magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
stepIcon rendered XCircle for the done state, so every completed step in the create-workspace progress list showed the error glyph — and in the current palette its emerald color class resolves to no CSS rule at all, leaving an invisibly-colored X. Use CircleCheck (the same glyph the notification center uses for success) with the green success color.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@magic-peach is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@benjaminshafii could you please review my pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the create-workspace progress list,
stepIconrendersXCirclefor thedonestate — the same glyph it uses forerror. So every successfully completed step shows an ✕ instead of a check. On currentdevit's compounded by the icon'stext-emerald-10class, which doesn't exist in the app's Radix-only Tailwind palette (see #2341), so the ✕ also renders with no color of its own.apps/app/src/react-app/domains/workspace/create-workspace-local-panel.tsx:donenow rendersCircleCheck— the same success glyph the notification center uses — intext-green-10, which exists in the palette.errorkeepsXCirclein red, so the two states are finally distinguishable at a glance.Testing
pnpm typecheck— cleanbun test tests/— 142 pass, 0 failstepIconhelper; the reviewer can reproduce by creating a local workspace and expanding the progress details while steps complete.