fix(settings): fix theme picker previews inheriting active theme (#2328)#2486
Open
SumanMadipeddi wants to merge 1 commit into
Open
fix(settings): fix theme picker previews inheriting active theme (#2328)#2486SumanMadipeddi wants to merge 1 commit into
SumanMadipeddi wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@SumanMadipeddi is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg-zinc-950withbg-blackin the dark theme card and the system theme split card.Why
bg-zinc-950was used, but the theme's custom Tailwind color palette overrides default colors and does not include thezincscale. Replacing it withbg-blackensures the preview background displays solid black.Issue
Scope
apps/app/src/react-app/domains/settings/appearance/theme-section.tsxOut of scope
Testing
Ran
pnpm typecheckpnpm test:e2epnpm fraimz --flow app-smokeResult
CI status
Manual verification
Evidence
Risk