Skip to content

fix(settings): fix theme picker previews inheriting active theme (#2328)#2486

Open
SumanMadipeddi wants to merge 1 commit into
different-ai:devfrom
SumanMadipeddi:fix/theme-picker-previews-2328
Open

fix(settings): fix theme picker previews inheriting active theme (#2328)#2486
SumanMadipeddi wants to merge 1 commit into
different-ai:devfrom
SumanMadipeddi:fix/theme-picker-previews-2328

Conversation

@SumanMadipeddi

Copy link
Copy Markdown
Contributor

Summary

  • Replaced bg-zinc-950 with bg-black in the dark theme card and the system theme split card.

Why

  • The theme picker cards in Settings > Appearance did not maintain their preview colors and instead inherited the active theme (e.g. the dark card became white in light mode).
  • This happened because bg-zinc-950 was used, but the theme's custom Tailwind color palette overrides default colors and does not include the zinc scale. Replacing it with bg-black ensures the preview background displays solid black.

Issue

Scope

  • apps/app/src/react-app/domains/settings/appearance/theme-section.tsx

Out of scope

  • Changing global theme CSS classes or modifying Tailwind colors configuration.

Testing

Ran

  • pnpm typecheck
  • pnpm test:e2e
  • pnpm fraimz --flow app-smoke

Result

  • pass/fail: pass

CI status

  • pass: pass (typecheck and Playwright e2e test suite complete)

Manual verification

  1. Open settings in the desktop app and select Appearance.
  2. Switch active theme mode to Light.
  3. Confirm that the Dark preview card remains black, and the System preview card remains split white and black.

Evidence

image

Risk

  • Low. Only styles dark and split elements in theme preview items.

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-landing Ready Ready Preview, Comment, Open in v0 Jul 5, 2026 3:45am

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

@SumanMadipeddi is attempting to deploy a commit to the Different AI Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Theme picker previews inherit the active theme

1 participant