Skip to content

Add seed argument to EnsembleSampler#376

Open
dfm wants to merge 20 commits into
dfm:mainfrom
OriolAbril:master
Open

Add seed argument to EnsembleSampler#376
dfm wants to merge 20 commits into
dfm:mainfrom
OriolAbril:master

Conversation

@dfm

@dfm dfm commented Jan 16, 2021

Copy link
Copy Markdown
Owner

This was previously opened as #332, but because of branch renaming issues we had to reopen it. This is @OriolAbril's work, but @carlosgmartin might also be interested. I'll try to summarize where we stand from the previous thread shortly, but I think we were just about there. Anything in particular that was missing?

@dfm

dfm commented Jan 16, 2021

Copy link
Copy Markdown
Owner Author

The tests are failing because we need to change

import packaging

to

import packaging.version

@dfm

dfm commented Jan 16, 2021

Copy link
Copy Markdown
Owner Author

@OriolAbril: If you check the "allow edits from maintainers" checkbox, then I can take over from here.

@OriolAbril

OriolAbril commented Jan 16, 2021

Copy link
Copy Markdown
Contributor

I don't have the option to either, probably because I did not open the PR, but I can give both you and @carlosgmartin access to my fork.

@HealthyPear

Copy link
Copy Markdown

What is the status of this PR? Any change it can go in a new release?

@andyfaff

Copy link
Copy Markdown
Contributor

I should point out SPEC-007, which is trying to normalise how random numbers are using within the scientific ecosystem. The main items are converging on the use of an rng keyword, and a move to using Generator instead of of RandomState

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants