Repository navigation
ci: check PR titles with a workflow instead of the semantic-prs app - #2813
Merged
Merged
Conversation
The Ezard/semantic-prs app parses titles as conventional commits, whose types are one word, so the configured 'new icon' / 'update icon' types never match and every icon PR fails 'Semantic PR'. pr_title.yml checks the same rules (plus the icon formats) with a few lines of github-script, keeps the check name, and explains the expected format in the job summary. semantic.yml now only turns the app off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Snailedlt
marked this pull request as draft
October 28, 2026 12:15
Collaborator
Author
|
@ReenigneArcher please take a look :) |
- delete semantic.yml (the app gets uninstalled) - run on ubuntu-latest - pin github-script to a commit SHA - show the title as text in the job summary - drop the history comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Snailedlt
marked this pull request as ready for review
October 28, 2026 17:43
Snailedlt
requested review from
a team,
Yashh56,
canaleal,
lunatic-fox and
weh
and removed request for
a team
October 28, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepared by Claude (an AI assistant) on behalf of @Snailedlt.
Double check these details before you open a PR
Features
Every icon PR currently fails the Semantic PR check, even with a correct title like
new icon: nx (original, line)(see #2794 or #2786). Conventional titles likefix: ...pass.The semantic-prs app parses titles as conventional commits, where a type is a single word. So the
new iconandupdate icontypes in.github/semantic.ymlcan never match: the parser stops at the space.This PR keeps the same rules but checks them with a small workflow,
.github/workflows/pr_title.yml:actions/github-script(pinned to a commit SHA) and nothing third-party, with no token permissions (permissions: {}). The title is only read as data, never interpolated into${{ }}or a shell, so it can't inject code.new icon: <name> (<versions>),update icon: <name> (<versions>), and conventional-commit titles (feat,fix,docs,chore,ci,refactor,style,test,perf,build,revert, with an optional scope and!), as well as GitHub'sRevert "..."titles..github/semantic.ymlis deleted; the app should be uninstalled from the repo.Notes
@ReenigneArcher, you set up the semantic-prs config in #2437 and #2767. Could you take a look, in case there's an app setting we missed that would make the icon types work?
🤖 Generated with Claude Code