Skip to content

common-utils: Add sandboxing dependencies and distro coverage - #1752

Merged
Abdurrahmaan Iqbal (abdurriq) merged 1 commit into
mainfrom
common-utils-sandbox-dependencies
Oct 9, 2026
Merged

Abdurrahmaan Iqbal (abdurriq) merged 1 commit into
mainfrom
common-utils-sandbox-dependencies

Conversation

@chrmarti

Copy link
Copy Markdown
Contributor

Summary

  • Install slirp4netns, util-linux, and iptables alongside bubblewrap for sandboxing and sandbox networking.
  • Keep bubblewrap/slirp4netns optional where RPM repositories do not provide them, with explicit skip messages. Query after enabling EPEL and use microdnf repoquery on minimal images (microdnf list is unsupported).
  • Extend command/version checks across the configured distro/version scenarios, including Debian, older Alpine releases, CentOS, AlmaLinux/Rocky minimal images, Mariner, Azure Linux, and UBI.
  • Update the included-utilities notes and bump common-utils to 2.7.1.

Validation

  • All 25 modified shell scripts pass bash -n; git diff --check passes.
  • Generic feature tests passed on Ubuntu Jammy, Alpine 3.18, and Rocky Linux 9.
  • All 16 newly covered scenarios passed across the full run and targeted reruns: Bookworm, Trixie, CentOS 7, AlmaLinux 8, AlmaLinux 8/9 minimal, Rocky Linux 8, Rocky Linux 8/9 minimal, Mariner 2.0, Azure Linux 3.0, UBI 8.10, Alpine 3.14/3.15/3.18, and the Alpine devcontainer base.
  • The initial minimal-image failures exposed the unsupported microdnf query. After fixing it, all seven targeted RPM regression scenarios passed.
  • Local tests used LF-normalized temporary copies because the Windows checkout uses CRLF. UID remapping was disabled only in temporary scenario configurations to avoid mapping test users to the WSL host's root UID; repository scenarios are unchanged.

Reviewer notes

  • Mariner/Azure Linux currently lack slirp4netns, and UBI 8 lacks bubblewrap. Their tests check repository availability and explicitly report these expected skips; repository-query failures are not silently ignored.
  • Tests verify command availability/version output, not functional sandbox execution.
  • Existing CI coverage is unchanged: no common-utils ARM64 matrix was added, and existing continue-on-error settings remain unchanged.

Install slirp4netns, util-linux, and iptables alongside bubblewrap. Handle optional RPM packages with microdnf repoquery support, and verify sandbox commands across the configured distro/version scenarios.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@chrmarti
Christof Marti (chrmarti) marked this pull request as ready for review October 9, 2026 12:49
@chrmarti
Christof Marti (chrmarti) requested a review from a team as a code owner October 9, 2026 12:49
@abdurriq
Abdurrahmaan Iqbal (abdurriq) merged commit 94181c0 into main Oct 9, 2026
15 checks passed
@abdurriq
Abdurrahmaan Iqbal (abdurriq) deleted the common-utils-sandbox-dependencies branch October 9, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants