Repository navigation
Fix command output truncated at first empty line - #4259
Open
christian-klemmer wants to merge 1 commit into
Open
christian-klemmer wants to merge 1 commit into
christian-klemmer wants to merge 1 commit into
Conversation
Logger::print() returned from the whole method when it hit an empty line, so everything after it was dropped from the console output and the file log. Because the check used empty(), a line containing only "0" also cut the output off. Skip empty lines with a strict `$line === ''` check and `continue` instead of `return`. Refs: deployphp#4256
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regression described in #4256.
Logger::print()returned from the whole method when it hit an empty line, so everything after it was missing from the console output and from the file log. Because the check usedempty(), a linecontaining only
"0"also cut the output off.This shows up with any command whose output contains blank lines, for example test results or coverage reports in CI.
Changes
empty($line)with a strict$line === ''check, so"0"lines are kept.continueinstead ofreturn, so only the empty line is skipped and the rest of the buffer is still printed and logged.LoggerTestcovering console output and file logging with blank lines and"0"lines.Empty lines are still dropped, as before. Only the truncation is fixed.