Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

const fs = require('fs');
const { builtinModules } = require('module');
const path = require('path');
const process = require('process');
const { debuglog } = require('util');
const getModuleType = require('module-definition');
const Walker = require('node-source-walk');
Expand All @@ -18,8 +18,6 @@ const detectiveTypeScript = require('detective-typescript');
const detectiveVue = require('detective-vue2');

const debug = debuglog('precinct');
// eslint-disable-next-line n/no-deprecated-api
const natives = process.binding('natives');

/**
* Finds the list of dependencies for the given file
Expand Down Expand Up @@ -129,7 +127,7 @@ precinct.paperwork = (filename, options = {}) => {
return true;
}

return !natives[dependency];
return !builtinModules.includes(dependency);
});
}

Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/nodeBuiltinPrefix.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const fs = require('node:fs');
const path = require('node:path');
const myModule = require('./myModule');
15 changes: 15 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -394,13 +394,28 @@ describe('node-precinct', () => {
assert.deepEqual(result, ['streams']);
});

it('does not filter out node:-prefixed builtins by default', () => {
const fixture = path.join(__dirname, 'fixtures', 'nodeBuiltinPrefix.js');
const result = precinct.paperwork(fixture);
assert.ok(result.includes('node:fs'));
assert.ok(result.includes('node:path'));
});

it('understands quirks around some modules only being addressable via node: prefix', () => {
const fixture = path.join(__dirname, 'fixtures', 'requiretest.js');
const result = precinct.paperwork(fixture, {
includeCore: false
});
assert.deepEqual(result, ['test']);
});

it('filters out node:-prefixed builtins when includeCore is false', () => {
const fixture = path.join(__dirname, 'fixtures', 'nodeBuiltinPrefix.js');
const result = precinct.paperwork(fixture, {
includeCore: false
});
assert.deepEqual(result, ['./myModule']);
});
});

describe('that uses dynamic imports', () => {
Expand Down
Loading