fix(cron): honor equal jitter bounds and reject negative MinSec#736
Merged
Conversation
computeJitter's guard treated MinSec == MaxSec as "no jitter" (returned 0), so a job configured with a fixed offset (min == max) got no jitter at all instead of that exact offset. It also let a negative MinSec through, which could produce a negative jitter duration subtracted from the fire time. Guard on MinSec > MaxSec (still zero) and MinSec < 0 (invalid, zero) instead of MinSec >= MaxSec. Now min == max yields exactly MinSec seconds, and negative MinSec is rejected. Tests split accordingly (EqualBounds, MinGreaterThanMax). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182aJaeQgukK1vkNjy95wt6
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
computeJitter's guard wasMinSec >= MaxSec → return 0. Two edge-case bugs:MinSec == MaxSec(a fixed offset) returned 0 — no jitter — instead of that exact offset.MinSecslipped through (sincemin < max), sorawcould land in e.g.[-60, 300]— a negative jitter subtracted from the fire time.Fix
Guard on
MinSec > MaxSec(zero) andMinSec < 0(invalid → zero) instead of>=. Nowmin == maxyields exactlyMinSecseconds (verified:span=0,IntN(1)=0,raw=MinSec), and negative min is rejected. Tests split intoEqualBoundsandMinGreaterThanMax; cron package green under-race.🤖 Generated with Claude Code