Conversation
Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added an
@lru_cachehelper toget_models.pyto cache the parsing ofmodels.yml.🎯 Why: The previous code was calling
yaml.safe_loadon disk reads repeatedly whenever models were fetched or updated. YAML parsing is slow, and caching the parsed read-only structure significantly speeds up loading subsets of models or fetching registry information.📊 Impact: Expected ~95% reduction in execution time for calls to
get_model_nameson consecutive requests (e.g., drops from ~10ms down to near 0ms in Python tests, significantly improving interactive UI speed when the registry is queried multiple times).🔬 Measurement: Run a script calling
get_model_names()repeatedly to observe the time difference between the first load and subsequent loads.PR created automatically by Jules for task 18210903606570125460 started by @alinelena