Setup solid-state electrolytes benchmark#394
Setup solid-state electrolytes benchmark#394ThiagoReschutzegger wants to merge 17 commits intoddmms:mainfrom
Conversation
Co-authored-by: Joseph Hart <92541539+joehart2001@users.noreply.github.com>
|
Just putting this here do i don't forget and to tag @ElliottKasoar: as the PNAS rdf metric is becoming a common metric to use, we will add a generalised version you'll be able to call. i'll tag you when thats been implemented |
| / "SSE" | ||
| ) | ||
|
|
||
| # TODO: Check if it is possible to parallelize over systems |
There was a problem hiding this comment.
Hey, would you be able to take a look at an approach done in the liquid densities MD benchmark (this was just added recently) which uses a conftest so then we can run with e.g. array jobs. i think this would be a good appraoch and also consistent with the other benchamrks.
There was a problem hiding this comment.
Thanks for pointing that out! Just updated the code according to the example above. However, I could not test if parallelization across GPUs works locally. Let me know if further adjustments are needed.
There was a problem hiding this comment.
Great! I’ll try to test this soon, probably after @ElliottKasoar has also had a look over the PR. Thanks!
Pre-review checklist for PR author
Summary
This pull request introduces initial support for benchmarking solid-state electrolytes (SSEs) within the project. It adds documentation, configuration, metrics, calculation scripts, and an app interface for the new benchmark, called SSE-MD.
Implemented the main calculation script for the SSE-MD RDF benchmark, including test generation, MD simulation setup, and trajectory processing for multiple ML models. Added a metrics definition file for SSE-MD, specifying the score metric and its properties.
Linked issue
Resolves #393
Progress
Testing
I tested the benchmark on MACE-MP-0 and MACE-MP-0B3.
New decorators/callbacks
No new callbacks are required.