highlight multiple constellations - #29
Open
tbartic wants to merge 11 commits into
Open
Conversation
the original code would keep opening the outline file for every chart in the configuration file. That is fine as long as the number of files is small, in my case below 5. If one wants to generate more charts in one config file one runs into problems with the ulimit. This code, generated by claude, fixes the issue by splitting the file opening and drawing in two separete functions.
…stead of one constellation constellation_highlight had been originally made to read one three letter abbreviation of a constellation. the new version has the ability to read an entire string of several constellations separated by commas.
file opening and drawing split
constellation_highlight was limited to an array of 8 bytes which is too short for holding a series of constellations. It has now been upgraded to a much longer one so that we can highlight mulitple constellations
…nstellations Added functionality to highlight constellations based on a comma-separated list of 3-letter abbreviations. The code now parses the highlight list and checks if each constellation is in the highlight list to set the appropriate line color and width.
Comment out test chart generation and related commands
Updated 'force_refresh' to use the 'refresh' variable instead of a hardcoded True.
replaced except Value Error with except (ValueError, IndexError):
Fixed warnin about unsigned char C[V_SIZE_MAP1][H_SIZE_MAP1];
Updated the `constellation_highlight` option to allow highlighting multiple constellations with a comma-separated list. Configuration file can now have more than just 5 charts in one file and does not run in ulimit limitation.
Removed unnecessary variable 'was_highlighted' used for tracking highlight state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code has been modified to (all code has been generated and debugged using claude.ai):