Remove redundant reminders from the config wizard#721
Merged
Conversation
Two wizard notes restated information the operator already knows: the 'users.yaml already configured / edit it directly or use Telegram commands' block on the existing-config path, and the 'per-user PR review toggle lives in users.yaml or /github reviews' line under the PR review section. Drop both. The user-setup case folds into a single not-users_yaml_exists guard (the removed branch only computed a cosmetic summary string for the deleted message); the section headers stay as structural markers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two
make confignotes that restate information the operator already has, so the wizard output is less noisy.users.yaml already configured (N users, M admins)andTo modify users, edit users.yaml directly or use Telegram commands. Dropped. That branch only computed a cosmetic summary string for the deleted message, so it collapses into a singleif not users_yaml_exists:guard around the first-time admin prompts.Per-user PR review toggle lives in users.yaml ('pr_review') or via /github reviews on|offline under the section header.The
-- User setup --and-- PR review agent --section headers stay (they are structural markers, consistent with every other wizard section).Tests
make checkclean; full suite passes (4600 passed, 1 skipped). The existing-users.yaml wizard test no longer asserts the removedalready configuredtext; it now verifies the stronger behavior directly (no admin prompt is shown and no users.yaml is staged when the canonical file already exists).