Skip to content

Minimize rebuilds on git version change - #1316

Open
nick87720z wants to merge 1 commit into
davatorium:nextfrom
nick87720z:git-ver-rebuild
Open

Minimize rebuilds on git version change#1316
nick87720z wants to merge 1 commit into
davatorium:nextfrom
nick87720z:git-ver-rebuild

Conversation

@nick87720z

@nick87720z nick87720z commented May 22, 2021

Copy link
Copy Markdown
Contributor

For now full rebuild happens when current commit changes, which may happen without actual content change - e.g. something is commited or uncommited via git reset without --hard option. This change makes only necessary files being rebuild - those, using GIT_REVISION.

@DaveDavenport

Copy link
Copy Markdown
Collaborator

@sardemff7 you added that option, any feedback on this.

I never had issues with this (But rofi compiles so quick, I would not have noticed anyway).

@sardemff7

Copy link
Copy Markdown
Collaborator

Seems like a good move, but you should put the #include next to the nkutils one, in an #else branch for line 50 #ifdef

It's headache when even doing commit leads to almost full rebuild due to
changed current git version without real content change.
@codecov-commenter

codecov-commenter commented May 23, 2021

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.04%. Comparing base (04c006a) to head (0614b9f).
⚠️ Report is 1017 commits behind head on next.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1316      +/-   ##
==========================================
+ Coverage   32.98%   33.04%   +0.06%     
==========================================
  Files          42       42              
  Lines       11934    12024      +90     
==========================================
+ Hits         3936     3973      +37     
- Misses       7998     8051      +53     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants