Skip to content

Clean up Custom DC HTML templates and CSS after site redesign#6100

Open
kmoscoe wants to merge 45 commits intodatacommonsorg:masterfrom
kmoscoe:env
Open

Clean up Custom DC HTML templates and CSS after site redesign#6100
kmoscoe wants to merge 45 commits intodatacommonsorg:masterfrom
kmoscoe:env

Conversation

@kmoscoe
Copy link
Contributor

@kmoscoe kmoscoe commented Mar 18, 2026

This PR does the following

  • Rewrite top-level comment in base.html and point to Docsite (also in homepage.html)
  • Chang title bar to use the NAME variable instead of hard-coded "Custom Data Commons".
  • Change name in custom_test.py to unbreak several Webdriver tests.
  • Remove unused scripts from bottom of base.html
  • Remove all unused styles from overrides.css
  • Remove Biomed example from browser landing page (that data is going away)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the documentation within the base.html template by providing clearer and more comprehensive comments. The changes aim to enhance developer understanding of template variables and blocks, making the template easier to use and maintain for current and future contributors.

Highlights

  • Documentation Clarity: Expanded comments in base.html to provide more detailed explanations for required and optional template variables, including their specific usage (e.g., title for browser title bar, main_id and page_id for CSS).
  • Template Block Explanation: Clarified the purpose of template blocks, renaming 'Blocks to override' to 'Blocks to include (used for CSS)' for better understanding of their function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kmoscoe kmoscoe changed the title Expand base.html comments to properly explain the use of the variables Expand custom base.html comments to properly explain the use of the variables Mar 18, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the comments in the base.html template to provide more detailed explanations for the required and optional variables. The changes are helpful, but I've pointed out one line where the new description is technically inaccurate regarding Jinja2 terminology and the purpose of the blocks. I've suggested a correction to improve clarity and correctness.

@kmoscoe kmoscoe requested a review from nick-nlb March 18, 2026 18:32
@kmoscoe kmoscoe marked this pull request as draft March 18, 2026 23:43
@kmoscoe kmoscoe requested review from nick-nlb and removed request for nick-nlb March 18, 2026 23:44
@kmoscoe kmoscoe marked this pull request as ready for review March 23, 2026 18:42
@kmoscoe kmoscoe removed the request for review from nick-nlb March 23, 2026 20:05
@kmoscoe kmoscoe marked this pull request as draft March 23, 2026 20:05
@kmoscoe kmoscoe changed the title Expand custom base.html comments to properly explain the use of the variables Clean up base.html to be more readable. Mar 25, 2026
@kmoscoe kmoscoe marked this pull request as ready for review March 25, 2026 01:58
@kmoscoe kmoscoe changed the title Clean up base.html to be more readable. Revise comments in custom base.html and homepage.html for clarity Mar 25, 2026
@kmoscoe kmoscoe requested a review from nick-nlb March 25, 2026 20:19
@kmoscoe kmoscoe changed the title Revise comments in custom base.html and homepage.html for clarity Clean up Custom DC HTML templates and CSS after site redesign Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant