Repository navigation
Run ruff via uv tool run so the SDK bumper can format pydabs - #7156
Merged
Merged
Conversation
The SDK bumper's image ships only the uv binary, not its uvx alias. pydabs-codegen's uvx ruff steps therefore failed there: the bumper's v0.190.0 PR (#7155) carried raw, unformatted pydabs codegen output with circular imports, which failed validate-generated, the Python tests and docs, and every pydabs acceptance test. bump-sdk-post stopped at that step, and generate-clijson-post ignores its error, so nothing surfaced in the bumper. - Call ruff as uv tool run ruff@0.15.17 (what uvx is an alias for) in python/Taskfile.yml and the root RUFF var. - bump-sdk skill: note that the bumper does not log the task's output and cannot run test-update (no ruff on PATH), and correct the claim that pypi.org is CI's default index. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
added a commit
that referenced
this pull request
Oct 22, 2026
What the bumper would have committed with #6987 and #7156: in its environment pydabs-codegen stopped at `uvx ruff ... format` (no uvx in the image), leaving raw, unformatted codegen output with circular imports and proxy URLs in python/codegen/uv.lock. - Rerun generate-check: only the pydabs models and generated tests change (ruff fix + format), down to the real v0.190.0 additions. - Restore python/codegen/uv.lock, which --frozen (#6987) leaves alone. - test-update: no golden changes. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 0d5a4f5
Top 3 slowest tests (at least 2 minutes):
|
…-run-ruff # Conflicts: # python/Taskfile.yml
rugpanov
approved these changes
Oct 22, 2026
Collaborator
Integration test reportCommit: e5cdfb9
17 interesting tests: 17 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
uv tool run ruff@0.15.17instead ofuvx ruff@0.15.17inpython/Taskfile.yml(pydabs-codegen,pydabs-fmt) and the rootRUFFvar.uvxis only an alias foruv tool run, so behavior is unchanged where both exist.bump-sdkskill: note that the SDK bumper does not logbump-sdk-post's output and cannot runtest-update(noruffon itsPATH), and correct the claim thatpypi.orgis CI's default index (CI's test jobs pointUV_INDEX_URLat a JFrog mirror).Why
The SDK bumper's image ships only the
uvbinary, notuvx. In the v0.190.0 bump (#7155),pydabs-codegenran codegen and then failed onuvx ruff ... format(theruff check --fixbefore it is|| true). The PR therefore carried raw, unformatted pydabs output with circular imports. That failedvalidate-generated, the Python tests and docs, and every acceptance test that imports the pydabs wheel.bump-sdk-poststopped at that step, sotest-updatenever ran, andgenerate-clijson-postignores the error, so nothing surfaced in the bumper.The lock-file half of that failure (proxy URLs left in
python/codegen/uv.lock) was fixed separately by #6987 (uv run --frozen); this branch hasmainmerged with that change.Tests
PATHthat hasuvbut nouvx:pydabs-codegenon Update Go SDK to v0.190.0 #7155's base produced output byte-identical to the bumper's commit. With this change and the samePATH, it succeeds, and the pydabs diff shrinks from 703 files to the 13 real SDK changes, all ruff-formatted.main(with PyDABs: Pass --frozen to uv run so the Taskfile never rewrites uv.lock #6987),pydabs-codegenwithoutuvxreproducesmain's pydabs output exactly and leaves both lock files untouched../task lint-python fmt-python checks.This pull request and its description were written by Isaac.