Repository navigation
direct: drop redundant dashboards RemapState - #6798
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: af6bb8f
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
September 22, 2026 14:14
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
DoRead and the create/update builder (responseToState) already force EmbedCredentials into ForceSendFields, and the output-only fields RemapState excluded from ForceSendFields are never force-sent by the API response, so its exclusion was a no-op. RemapState was therefore identity-equivalent; remove it. Prep for replacing RemapState with the automatic copier. No golden changes. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/dashboards-fsf-doread
branch
from
September 22, 2026 17:39
99e1db4 to
af6bb8f
Compare
denik
enabled auto-merge
September 23, 2026 08:39
janniklasrose
approved these changes
Sep 23, 2026
Collaborator
Integration test reportCommit: f2b05e9
204 interesting tests: 138 FAIL, 66 MISS
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep toward replacing hand-written
RemapStatewith the automatic copier.dashboards'RemapStateforcedEmbedCredentialsintoForceSendFieldsand excluded output-only fields from it. ButDoReadand the shared create/update builder (responseToState) already forceEmbedCredentials, and the output-only fields are never present in the API response'sForceSendFields, so the exclusion was a no-op.RemapStatewas identity-equivalent — removed. No golden changes; acceptance passes.This pull request and its description were written by Isaac.