Improve code execution and synthetic data generation skills#403
Open
QuentinAmbard wants to merge 33 commits intomainfrom
Open
Improve code execution and synthetic data generation skills#403QuentinAmbard wants to merge 33 commits intomainfrom
QuentinAmbard wants to merge 33 commits intomainfrom
Conversation
Added missing documentation from production dashboard generation: 1-widget-specifications.md: - Combo charts (bar + line on same widget) with version 1 - Counter number formatting (currency, percent, plain number) - Widget name max length (60 characters) - Color scale restrictions (no scheme/colorRamp/mappings) - Quantitative color encoding for gradient effects - Bar chart group vs stacked decision criteria with examples 2-filters.md: - Date range picker complete example - Multi-dataset filter binding (one query per dataset) - Global filter performance note (auto WHERE clause) SKILL.md: - ORDER BY guidance for time series and rankings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
When a dimension has too many values (50+ stores, products, etc.), charts become unreadable. Added guidance to: - Check cardinality via get_table_details before charting - Use TOP-N + "Other" SQL pattern to bucket low-value items - Aggregate to higher abstraction level as alternative - Use table widgets for high-cardinality data 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The codebase doesn't use async anywhere else, so remove the unused async version of deploy_dashboard and keep only the synchronous one. - Remove asyncio import - Remove async deploy_dashboard function (was using asyncio.to_thread) - Rename deploy_dashboard_sync to deploy_dashboard - Update exports in __init__.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Allow linking a Genie space to a dashboard by passing genie_space_id. This enables the "Ask Genie" button on the dashboard UI. The Genie space config is injected into the serialized_dashboard JSON under uiSettings.genieSpace with isEnabled=true and enablementMode=ENABLED. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Allow setting default catalog and schema for dashboard datasets via the dataset_catalog and dataset_schema API parameters. These defaults apply to unqualified table names in SQL queries. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Document field-based filtering (automatic IN_RANGE on date fields) - Document parameter-based filtering (:date_range.min/max in SQL) - Show how to combine both approaches in one filter - Add guidance on when NOT to apply date filtering (MRR, all-time totals) - Update SKILL.md tools table with new genie_space_id, catalog, schema params 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Split widget specs into basic (1-widget-specifications.md) and advanced (2-advanced-widget-specifications.md) files - Add area chart, scatter plot, combo chart, and choropleth map documentation - Rename files for consistent numbering (3-filters, 4-examples, 5-troubleshooting) - Remove duplicate information across files (versions, naming rules, etc.) - Add widget display formatting guidance (currency, percentage, displayName) - Simplify SKILL.md quality checklist with link to version table - Shorten verbose examples while preserving all critical information - Clarify query naming convention for charts vs filters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Counter: full Pattern 2 example with CRITICAL field name matching note - Table: disaggregated:true guidance and bold emphasis - Line/Bar: x,y,color encodings and disaggregated guidance - Pie: 3-8 category limit for readability
- 5-troubleshooting.md: Restore full troubleshooting content with version guidance, filter debugging, and detailed error explanations - SKILL.md: Restore full 10-item quality checklist - SKILL.md: Restore standard dashboard structure example - SKILL.md: Restore cardinality guidance table (with softer 'suggested' language)
- Reduce docstring verbosity across all 18 tool files (~89% reduction) - Keep all functional information while being concise - Add skill references to complex tools (dashboards, vector search, genie, jobs, pipelines, lakebase, unity catalog, serving, apps, agent bricks) - Maintain human readability with bullet points and structure - Preserve critical warnings (ASK USER FIRST, CONFIRM WITH USER) - Keep return format hints for AI parsing Net reduction: 1,843 lines across 18 files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- agent_bricks.py: Add context for description, instructions, volume_path, examples - genie.py: Add context for table_identifiers, description, sample_questions, serialized_space - jobs.py: Add context for tasks, job_clusters, environments, schedule, git_source - lakebase.py: Add context for source_branch, ttl_seconds, is_protected, autoscaling params, and sync source/target table names - pipelines.py: Add context for root_path, workspace_file_paths, extra_settings, full_refresh 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Tool consolidations: - pipelines.py: 10→2 (manage_pipeline, manage_pipeline_run) - volume_files.py: 6→1 (manage_volume_files) - aibi_dashboards.py: 4→1 (manage_dashboard) - vector_search.py: 8→4 (manage_vs_endpoint, manage_vs_index, query_vs_index, manage_vs_data) - genie.py: 5→2 (manage_genie, ask_genie) - serving.py: 3→1 (manage_serving_endpoint) - apps.py: 3→1 (manage_app) - file.py: 2→1 (manage_workspace_files) - sql.py: 6→5 (manage_warehouse replaces list/get_best) - lakebase.py: 8→4 (manage_lakebase_database, manage_lakebase_branch, manage_lakebase_sync, generate_lakebase_credential) Key patterns: - All consolidated tools use an action parameter - Each action has required params documented in docstring - Error messages specify which params are required - Hot paths (query_vs_index, ask_genie) kept separate for clarity - All skills updated with action tables and examples 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Merged consolidated tool approach with dashboard-improvements params: - Combined manage_dashboard actions with genie_space_id, catalog, schema params - Updated SKILL.md to document consolidated tool with optional params 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Test infrastructure: - Add comprehensive integration tests for all MCP tools - Add test runner script with parallel execution support - Add fixtures for workspace, catalog, and resource cleanup - Add test resources (PDFs, SQL files, app configs) Bug fixes in databricks-tools-core: - Fix workspace file upload for directories - Fix job notebook path handling - Fix vector search index operations - Fix apps API responses - Fix dashboard widget handling - Fix agent bricks manager listing Bug fixes in MCP server tools: - Add quota skip handling for apps test - Fix genie space operations - Fix lakebase database operations - Fix compute cluster lifecycle handling - Fix dashboard operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace serialized_dashboard param with dashboard_file_path - Tool reads JSON from local file for easier iterative development - Update SKILL.md with new workflow documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Change simple_dashboard_json fixture to simple_dashboard_file - Update all manage_dashboard calls to use dashboard_file_path - Add tempfile imports and tmp_path usage for update test 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The Databricks SDK's w.apps.deploy() returns a Wait[AppDeployment] object, not an AppDeployment directly. The previous code passed the Wait object to _deployment_to_dict(), which caused getattr() to return None for all attributes since the Wait object doesn't have them. This fix uses wait_obj.response to get the actual AppDeployment object before converting it to a dictionary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The Databricks SDK's w.apps.deploy() returns a Wait[AppDeployment] object, not an AppDeployment directly. The previous code passed the Wait object to _deployment_to_dict(), which caused getattr() to return None for all attributes since the Wait object doesn't have them. This fix uses wait_obj.response to get the actual AppDeployment object before converting it to a dictionary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add tools summary table at top of MCP Tools section - Change code blocks from python syntax to plain text - Add "# MCP Tool: <name>" comments to clarify these are tool calls, not Python code - Move Supporting Tools table to main tools table 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove garbage characters from widget documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use w.genie.trash_space() in _delete_genie_resource - Add _find_space_by_name() using SDK's list_spaces with pagination - Use w.genie.update_space() and w.genie.create_space() for space management - Use w.genie.get_space() with include_serialized_space in _get_genie_space - Fix validation to allow space_id for updates without display_name 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add per-suite timeout in run_tests.py (10 min default, configurable) - Improve apps test with better cleanup and assertions - Add skip logic for quota-exceeded scenarios 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…cumentation Add detailed parameter documentation to all 9 Unity Catalog MCP tools: - manage_uc_objects: Document parameters by object_type (catalog/schema/volume/function) - manage_uc_grants: Add privilege lists per securable type - manage_uc_storage: Detail credential and external_location parameters - manage_uc_connections: Document connection_type options and create_foreign_catalog - manage_uc_tags: Detail set_tags/unset_tags/query parameters - manage_uc_security_policies: Document row filter and column mask parameters - manage_uc_monitors: Detail monitor creation and refresh parameters - manage_uc_sharing: Document share/recipient/provider resource types - manage_metric_views: Detail dimension/measure format and query parameters 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add clear instructions requiring users to: 0. Review the databricks-aibi-dashboards skill for widget JSON structure 1. Call get_table_stats_and_schema() for table schemas 2. Call execute_sql() to test EVERY query before use This prevents widgets from showing errors due to untested queries. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add Design Best Practices section for default dashboard behaviors
- Change /tmp paths to ./ for less opinionated examples
- Update parent_path example to use {user_email} placeholder
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Execution compute skill: - Split into 3 clear execution modes: Databricks Connect (default), Serverless Job, Interactive Cluster - Add decision matrix for choosing execution mode - Add job_extra_params for custom dependencies in serverless jobs - Create dedicated reference files for each mode Synthetic data gen skill: - Emphasize business story: problem → impact → analysis → solution - Add guidance to propose compelling stories by default - Consolidate reference files (6 → 2) - Add critical rules for data coherence and Databricks value - Clarify when to read reference files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add Critical Rule #12: No Python loops or .collect() - Add Performance Rules section with anti-pattern table - Emphasize Spark parallelism over driver-side iteration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace basic NYC taxi examples with complete Sales Analytics dashboard - Add critical widget version requirements table to SKILL.md - Add data validation guidance to verify dashboards tell intended story - Document key patterns: page types, KPI formatting, filter binding, layout grid 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Require agent to read 4-examples.md before creating dashboards, and if unfamiliar, read full skill documentation first. Valid JSON is critical. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch Relationships
This branch (
code-execution-improvements) is the MOST COMPLETE - it contains:mcp-tool-token-optimizationdashboard-improvements(cherry-picked)Merge Order
mcp-tool-token-optimization) - Base changesdashboard-improvements) - Dashboard skill improvementscode-execution-improvements) - This PR, execution compute + synthetic data skillsTest plan
🤖 Generated with Claude Code