fix(query): scope HTTP session state by tenant#19931
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26f82c14a7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| user_name: &str, | ||
| session_id: &str, | ||
| ) -> String { | ||
| format!("{}/{user_name}/{session_id}", tenant.tenant_name()) |
There was a problem hiding this comment.
When an HTTP temp table exists, ClientSessionManager::get_all_temp_tables() now returns keys built by this helper, but system.temporary_tables still decodes every key as user/session_id (temporary_tables_table.rs lines 120-121). With the new tenant/user/session_id format, that table reports the tenant as the user and the user name as the session id, so is_current_session also never matches the real client session id for HTTP sessions. Please update the HTTP parsing/display path or keep the tenant-scoped map key separate from the two-part session key exposed to this table.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@3em0 thanks for your contribution. this does need to be fixed
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
|
sorry！ i am late to fix it |
|
@3em0 need pass check to start tests. |
Resolve `clippy::items_after_test_module` errors that failed the linux/check and mac_check CI jobs by moving the items declared after the `#[cfg(test)] mod tests` blocks to before them, so each test module is the last item in its file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 participants
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
user/client_session_idin-memory key.Fixes #19930
Tests
cargo/Rust toolchain is not installed in this environment, so I could not execute the added unit tests locally. I rangit diff --checksuccessfully.Type of change
This change is