Fix overflow when encoding non-python data types#117
Open
AuthoStats wants to merge 2 commits intodata61:masterfrom
Open
Fix overflow when encoding non-python data types#117AuthoStats wants to merge 2 commits intodata61:masterfrom
AuthoStats wants to merge 2 commits intodata61:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Issue#116 for an example of the issue.
Added a UnitTest that fails without the fix. UnitTest requires Numpy to work, as Numpy has data types such as int64 that cause overflow because the int_rep conversion doesn't properly convert into a python int, which is needed to prevent overflow in the modulus operation.
One Working fix is to just convert the int_rep into a python int manually by wrapping it in the int() function.