Add PATCH to HttpMethods enum for service invocation#1623
Merged
salaboy merged 3 commits intodapr:masterfrom Feb 2, 2026
Merged
Add PATCH to HttpMethods enum for service invocation#1623salaboy merged 3 commits intodapr:masterfrom
salaboy merged 3 commits intodapr:masterfrom
Conversation
lindner
force-pushed
the
add-patch-http-method
branch
from
c703f67 to
443b03d
Compare
Collaborator
|
@lindner thanks for the contribution. We will definitely need a test for this. I would recommend you an integration test too using test container to validate that the change works using the sidecar. |
Contributor
Author
Can you help me identify the correct place for this? It's just another HTTP verb, so I don't think it's going to need much... |
Collaborator
|
@lindner I think adding a test here will be enough: https://github.com/dapr/java-sdk/blob/master/sdk/src/test/java/io/dapr/client/DaprHttpTest.java#L247 |
salaboy
requested changes
Jan 30, 2026
Collaborator
salaboy
left a comment
salaboy
left a comment
There was a problem hiding this comment.
this change is great but we need tests, one test here will be enough: https://github.com/dapr/java-sdk/blob/master/sdk/src/test/java/io/dapr/client/DaprHttpTest.java#L247
lindner
force-pushed
the
add-patch-http-method
branch
from
ce4b3c7 to
68f006f
Compare
Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints. This is commonly required for partial updates when calling external REST APIs via Dapr service invocation. Fixes dapr#1622 Signed-off-by: Paul Lindner <plindner@metropolis.io>
Signed-off-by: Paul Lindner <plindner@metropolis.io>
lindner
force-pushed
the
add-patch-http-method
branch
from
68f006f to
a2ac14a
Compare
javier-aliaga
approved these changes
Feb 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
============================================
- Coverage 79.02% 78.97% -0.05%
Complexity 2097 2097
============================================
Files 228 228
Lines 6321 6322 +1
Branches 693 693
============================================
- Hits 4995 4993 -2
- Misses 975 978 +3
Partials 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 2, 2026
* Add PATCH to HttpMethods enum for service invocation Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints. This is commonly required for partial updates when calling external REST APIs via Dapr service invocation. Fixes dapr#1622 Signed-off-by: Paul Lindner <plindner@metropolis.io> * Add test for PATCH HTTP method Signed-off-by: Paul Lindner <plindner@metropolis.io> --------- Signed-off-by: Paul Lindner <plindner@metropolis.io> Co-authored-by: salaboy <Salaboy@gmail.com>
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 2, 2026
* Add PATCH to HttpMethods enum for service invocation Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints. This is commonly required for partial updates when calling external REST APIs via Dapr service invocation. Fixes dapr#1622 Signed-off-by: Paul Lindner <plindner@metropolis.io> * Add test for PATCH HTTP method Signed-off-by: Paul Lindner <plindner@metropolis.io> --------- Signed-off-by: Paul Lindner <plindner@metropolis.io> Co-authored-by: salaboy <Salaboy@gmail.com> Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 2, 2026
* Add PATCH to HttpMethods enum for service invocation Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints. This is commonly required for partial updates when calling external REST APIs via Dapr service invocation. Fixes dapr#1622 Signed-off-by: Paul Lindner <plindner@metropolis.io> * Add test for PATCH HTTP method Signed-off-by: Paul Lindner <plindner@metropolis.io> --------- Signed-off-by: Paul Lindner <plindner@metropolis.io> Co-authored-by: salaboy <Salaboy@gmail.com>
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 2, 2026
* Add PATCH to HttpMethods enum for service invocation Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints. This is commonly required for partial updates when calling external REST APIs via Dapr service invocation. Fixes dapr#1622 Signed-off-by: Paul Lindner <plindner@metropolis.io> * Add test for PATCH HTTP method Signed-off-by: Paul Lindner <plindner@metropolis.io> --------- Signed-off-by: Paul Lindner <plindner@metropolis.io> Co-authored-by: salaboy <Salaboy@gmail.com> Signed-off-by: Javier Aliaga <javier@diagrid.io>
salaboy
added a commit
that referenced
this pull request
Feb 2, 2026
* push removing unnecesary var (#1634) Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Replace old log based waits with DaprWait strategy. (#1635) * Replace old log based waits with DaprWait strategy. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Revert ConsumerAppIT to make tests pass. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Revert ConsumerAppIT so there are no changes. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Disable the IT test for failing CI. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Add PATCH to HttpMethods enum for service invocation (#1623) * Add PATCH to HttpMethods enum for service invocation Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints. This is commonly required for partial updates when calling external REST APIs via Dapr service invocation. Fixes #1622 Signed-off-by: Paul Lindner <plindner@metropolis.io> * Add test for PATCH HTTP method Signed-off-by: Paul Lindner <plindner@metropolis.io> --------- Signed-off-by: Paul Lindner <plindner@metropolis.io> Co-authored-by: salaboy <Salaboy@gmail.com> Signed-off-by: Javier Aliaga <javier@diagrid.io> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: Paul Lindner <plindner@metropolis.io> Co-authored-by: salaboy <Salaboy@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Paul Lindner <lindner@inuus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATCHto theHttpMethodsenum to enable usingDaprClient.invokeMethod()with PATCH requests through HTTPEndpointsTest plan
invokeMethod()for HTTPEndpoint service invocationFixes #1622