Open
Conversation
Collaborator
|
Hi, this needs a rebase before I can take a look. Also any chance you can write some tests for this? |
|
Yeah, I faced the same problem. It seems that the request body is invalid after calling retry(). I paste a log snippet below. ESC[32m[2014-10-27 17:08:39.730] [INFO] [default] - ESC[39mdid not return within 30000 ms, retry it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When first creating a request, this.options.data is converted to a string (if it's not already a string). That string is then converted to a buffer and transmitted as the request body.
When retrying a request, that buffer was stringified, then this string was converted to another buffer. The retry request body then looks bogus (like '0=123&1=34&2=105&3=100&4=34' ...)
The content-type header was also trounced with the value 'application/x-www-form-urlencoded'.
This fix puts the Buffer data in a different variable and prevents the data from being re-stringified and re-bufferified when when retry() is called.