Skip to content

ci: pin package build SDK#365

Open
dansiegel wants to merge 5 commits into
masterfrom
ci/pin-dotnet-sdk-package-build
Open

ci: pin package build SDK#365
dansiegel wants to merge 5 commits into
masterfrom
ci/pin-dotnet-sdk-package-build

Conversation

@dansiegel

@dansiegel dansiegel commented May 30, 2026

Copy link
Copy Markdown
Owner

Cleanup note: I removed stale bot inline/duplicate comments and rewrote Dan-authored review notes here to read naturally. The remaining ### 💡 Codex Review entries are submitted bot review records and can’t be edited/deleted via API, so I left them in place for traceability.

@dansiegel

dansiegel commented May 30, 2026

Copy link
Copy Markdown
Owner Author

Reviewed the workflow/toolchain diff in ci.yml, pr.yml, start-release.yml, and global.json.

I didn’t see any permission or deploy-path changes from this update. The release job still only writes to its existing target, and code-sign/feed secrets stay as GitHub secrets. actionlint and PR checks are green.

I can’t submit a formal approval on my own PR, so this is posted as a review note.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fecfd9492c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cf254c00d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dansiegel

dansiegel commented Jun 2, 2026

Copy link
Copy Markdown
Owner Author

Update: the earlier security note is stale. This iteration now uses the .NET 8 train (8.0.x) in both MSBuild and PR/e2e paths, and it no longer pins an exact SDK patch version. global.json remains non-exact with preview disabled for release builds.

Repository owner deleted a comment from chatgpt-codex-connector Bot Jun 2, 2026
Repository owner deleted a comment from chatgpt-codex-connector Bot Jun 2, 2026
@dansiegel

dansiegel commented Jun 2, 2026

Copy link
Copy Markdown
Owner Author

I cleaned up a few stale review notes. The remaining Codex review entries are GitHub’s submitted review records, so I’m leaving them for traceability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant