Skip to content

Fix #12699 QDir functions missing from qt.cfg #8349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 9 commits into
base: main
Choose a base branch
from
+134 −10
Open

Fix #12699 QDir functions missing from qt.cfg #8349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
05dfc6e
Update qt.cfg
chrchr-github May 2, 2024
44ad6a1
Update qt.cfg
chrchr-github May 2, 2024
7a1f85a
Merge branch 'danmar:main' into chr_qdir
chrchr-github Mar 18, 2026
dfefcf2
Update qt.cfg
chrchr-github Mar 18, 2026
ba7948c
Update qt.cfg
chrchr-github Mar 18, 2026
e69b0d8
Update qt.cfg [skip ci]
chrchr-github Mar 18, 2026
1010665
Update mainwindow.cpp [skip ci]
chrchr-github Mar 18, 2026
6c6b544
Update qt.cpp
chrchr-github Mar 18, 2026
2cbaab9
Fix
web-flow Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 110 additions & 9 deletions cfg/qt.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2319,10 +2319,28 @@
<not-bool/>
</arg>
</function>
<!-- bool QDir::mkdir(const QString &dirPath) const -->
<!-- bool QDir::mkpath(const QString &dirPath) const -->
<!-- do not mark as const as it is not const from a side effect standpoint-->
<function name="QDir::mkdir,QDir::mkpath">
<noreturn>false</noreturn>
<returnValue type="bool"/>
<use-retval type="error-code"/>
<arg nr="1" direction="in">
<not-uninit/>
<not-bool/>
</arg>
</function>
<!-- QString QDir::path() const -->
<function name="QDir::path">
<noreturn>false</noreturn>
<use-retval/>
<returnValue type="QString"/>
</function>
<!-- QString absolutePath() const -->
<!-- QString canonicalPath() const -->
<!-- QString dirName() const -->
<function name="QDir::absoluteFilePath,QDir::canonicalPath,QDir::dirName">
<function name="QDir::absolutePath,QDir::canonicalPath,QDir::dirName">
<noreturn>false</noreturn>
<returnValue type="QString"/>
<use-retval/>
Expand All @@ -2338,6 +2356,68 @@
<not-bool/>
</arg>
</function>
<!-- QString QDir::absoluteFilePath(const QString &fileName) -->
<function name="QDir::absoluteFilePath">
<noreturn>false</noreturn>
<returnValue type="QString"/>
<use-retval/>
<arg nr="1" direction="in">
<not-uninit/>
<not-bool/>
</arg>
<const/>
</function>
<!-- QString QDir::filePath(const QString &fileName) -->
<function name="QDir::filePath">
<noreturn>false</noreturn>
<returnValue type="QString"/>
<use-retval/>
<arg nr="1" direction="in">
<not-uninit/>
<not-bool/>
</arg>
<const/>
</function>
<!-- static QString QDir::cleanPath(const QString &path) -->
<function name="QDir::cleanPath">
<noreturn>false</noreturn>
<returnValue type="QString"/>
<arg nr="1" direction="in">
<not-uninit/>
<not-bool/>
</arg>
<const/>
</function>
<!-- static QString QDir::currentPath() -->
<!-- static QString QDir::tempPath() -->
<function name="QDir::currentPath,QDir::tempPath">
<noreturn>false</noreturn>
<returnValue type="QString"/>
<use-retval/>
<const/>
</function>
<!-- QStringList QDir::entryList(const QStringList &nameFilters, QDir::Filters filters = NoFilter, QDir::SortFlags sort = NoSort) const-->
<!-- QStringList QDir::entryList(QDir::Filters filters = NoFilter, QDir::SortFlags sort = NoSort)const-->
<function name="QDir::entryList">
<noreturn>false</noreturn>
<returnValue type="QStringList"/>
<use-retval/>
<arg nr="any">
<not-uninit/>
</arg>
<const/>
</function>
<!-- QFileInfoList QDir::entryInfoList(const QStringList &nameFilters, QDir::Filters filters = NoFilter, QDir::SortFlags sort = NoSort) const -->
<!-- QFileInfoList QDir::entryInfoList(QDir::Filters filters = NoFilter, QDir::SortFlags sort = NoSort) const -->
<function name="QDir::entryInfoList">
<noreturn>false</noreturn>
<returnValue type="QFileInfoList"/>
<use-retval/>
<arg nr="any">
<not-uninit/>
</arg>
<const/>
</function>
<!-- bool QDir::cdUp() -->
<function name="QDir::cdUp">
<noreturn>false</noreturn>
Expand All @@ -2346,7 +2426,7 @@
</function>
<!-- bool QDir::exists(QString &name) const -->
<!-- bool QDir::exists() const -->
<function name="QDir">
<function name="QDir::exists">
<noreturn>false</noreturn>
<returnValue type="bool"/>
<use-retval/>
Expand All @@ -2356,13 +2436,6 @@
<not-bool/>
</arg>
</function>
<!-- uint QDir::count() const -->
<function name="QDir::count">
<noreturn>false</noreturn>
<returnValue type="uint"/>
<use-retval/>
<const/>
</function>
<!-- bool QFile::exists(const QString &fileName) // static -->
<!-- bool QFile::exists() const -->
<function name="QFile::exists">
Expand All @@ -2375,6 +2448,34 @@
<not-bool/>
</arg>
</function>
<!-- uint QDir::count() const -->
<function name="QDir::count">
<noreturn>false</noreturn>
<returnValue type="uint"/>
<use-retval/>
<const/>
</function>
<!-- QChar QDir::separator() static -->
<function name="QDir::separator">
<noreturn>false</noreturn>
<returnValue type="QChar"/>
<use-retval/>
<const/>
</function>
<!-- QDir QDir::home() static -->
<function name="QDir::home">
<noreturn>false</noreturn>
<returnValue type="QDir"/>
<use-retval/>
<const/>
</function>
<!-- QString QDir::homePath() static -->
<function name="QDir::homePath">
<noreturn>false</noreturn>
<returnValue type="QString"/>
<use-retval/>
<const/>
</function>
<!-- bool QFile::open(OpenMode mode) -->
<!-- bool QFile::open(FILE *fh, OpenMode mode, FileHandleFlags handleFlags = DontCloseHandle) -->
<!-- bool QFile::open(int fd, OpenMode mode, FileHandleFlags handleFlags = DontCloseHandle) -->
Expand Down
23 changes: 23 additions & 0 deletions test/cfg/qt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include <QPointF>
#include <QRegion>
#include <QTransform>
#include <QDir>

// TODO: this is actually avilable via Core5Compat but I could not get it to work with pkg-config
#if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0))
Expand All @@ -54,6 +55,28 @@ int ignoredReturnValue_QSize_width(const QSize &s)
return s.width();
}


void ignoredReturnValue_QDir(const QString& dirname)
{
QDir dir(dirname);

// cppcheck-suppress ignoredReturnValue
dir.exists("abc");

// cppcheck-suppress ignoredReturnErrorCode
dir.mkdir("abc");

// cppcheck-suppress ignoredReturnValue
dir.count();

// cppcheck-suppress ignoredReturnValue
dir.filePath("abc");

// cppcheck-suppress ignoredReturnValue
dir.entryList();
}


void unusedVariable_QTransform()
{
// cppcheck-suppress unusedVariable
Expand Down
2 changes: 1 addition & 1 deletion tools/triage/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ MainWindow::MainWindow(QWidget *parent) :
std::srand(static_cast<unsigned int>(std::time(nullptr)));
QDir workFolder(WORK_FOLDER);
if (!workFolder.exists()) {
workFolder.mkdir(WORK_FOLDER);
(void)workFolder.mkdir(WORK_FOLDER);
}

ui->results->setContextMenuPolicy(Qt::CustomContextMenu);
Expand Down
Loading