Skip to content

Fix #14539: false positive: constParameterPointer with type alias #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludviggunne wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

Fix #14539: false positive: constParameterPointer with type alias #8310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb5c185
Add test
ludviggunne Mar 8, 2026
7aa3306
Fix #14539
ludviggunne Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/tokenize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2998,6 +2998,9 @@ bool Tokenizer::simplifyUsing()
if (!usingEnd)
continue;

for (Token *typeTok = start; typeTok != usingEnd; typeTok = typeTok->next())
typeTok->isSimplifiedTypedef(true);

// Move struct defined in using out of using.
// using T = struct t { }; => struct t { }; using T = struct t;
// fixme: this doesn't handle attributes
Expand Down
6 changes: 6 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4763,6 +4763,12 @@ class TestOther : public TestFixture {
" return [](int* p) { return *p; }(&i);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3:20]: (style) Parameter 'p' can be declared as pointer to const [constParameterPointer]\n", errout_str());

check("using IntPtr = int *;\n"
"int* foo(IntPtr bar) {\n"
" return bar = 0;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void constArray() {
Expand Down
Loading