Rewrite .gitignore and bump Strawberry CI to Perl 5.42/5.40 - #189
Merged
Conversation
Collapse 183 lines of per-directory generated-file entries into pattern-based rules (*.c, *.xs, Makefile, MYMETA.*, *_t.*, etc.), with explicit exceptions for the real sources encengine.c, Encode.xs, and Unicode/Unicode.xs. Also ignore .claude/. Verified no tracked file becomes ignored (git ls-files -ci empty) and all previously listed artifacts remain covered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dankogai
marked this pull request as ready for review
July 30, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
*.c,*.xs,Makefile,MYMETA.*,pm_to_blib,*_t.*, etc.). The three real tracked sources that would otherwise match are explicitly excepted:!/encengine.c,!/Encode.xs,!/Unicode/Unicode.xs. Also adds.claude/to the ignore list.Why
The old .gitignore enumerated every generated file per encoding directory, which meant new generated files needed manual entries. Patterns cover them all uniformly.
Reviewer notes
Both directions were verified:
git ls-files -ci --exclude-standardis empty (no tracked file becomes ignored), andgit check-ignoreconfirms every category from the old file — including all enc2xs-generated sources across Byte/CN/EBCDIC/JP/KR/Symbol/TW/Unicode — is still matched. One caveat: since*.c/*.xsare now broad, a newly added real C/XS source will need its own!exception (git warns ongit addof an ignored file, so this can't slip by silently).🤖 Generated with Claude Code