Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
+ Coverage 93.08% 93.13% +0.05%
==========================================
Files 23 23
Lines 4769 4781 +12
==========================================
+ Hits 4439 4453 +14
+ Misses 270 269 -1
+ Partials 60 59 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonklingele
left a comment
There was a problem hiding this comment.
Small nit, otherwise lgtm! 🚀
|
|
||
| serverURL, err := url.Parse(server.URL) | ||
| if err != nil { | ||
| continue |
There was a problem hiding this comment.
Should we panic here?
There was a problem hiding this comment.
Yeah, the thought did cross my mind. Furthering my original question, I wonder if we should hard reject relative URLs? My thought being that we're currently adding a dummy URL to the $schema field for relative URLs, but maybe we should just force people to always use absolute URLs from the start?
I suspect that's not necessary, just trying to mentally untangle it :)
Fixes #983.
There's an ongoing discussion in that issue regarding my suggestion to always use absolute URLs rather than relative URLs for the generated
$schemafield.Would appreciate additional input, particularly from @danielgtaylor and @leonklingele :)