Repository navigation
fix: validate the same body keys the decoder assigns - #1172
Merged
Merged
Conversation
encoding/json matches keys case-insensitively and merges duplicate object keys, while validation saw a single key per property and only the last duplicate. CBOR's decoder defaults behave the same way. Validate every case-variant key against its property schema, reject duplicate object keys when DefaultJSONFormat decodes for validation, and decode CBOR with exact-case field names and no duplicate keys.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
+ Coverage 94.75% 95.08% +0.33%
==========================================
Files 25 30 +5
Lines 5224 5882 +658
==========================================
+ Hits 4950 5593 +643
- Misses 269 284 +15
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation and decoding now agree on which keys a request body contains. encoding/json assigns case-variant keys ("Role" for
role) and merges duplicate object keys, while validation checked one key per property and only the last duplicate. This validates every case variant against its property, rejects duplicate keys inDefaultJSONFormat, and decodes CBOR with exact-case field names and no duplicate keys.BenchmarkFullRequest_Complex, no extra allocations.