Repository navigation
fix(autopatch): keep every value of multi-value headers - #1166
Merged
Merged
Conversation
The PATCH handler copied the headers of the internal PUT response, and of a failed GET, with one SetHeader call per value, so only the last value of each header survived. A PATCH whose PUT set two cookies only sent the second one. Set the first value and append the others.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 94.75% 95.08% +0.33%
==========================================
Files 25 30 +5
Lines 5224 5885 +661
==========================================
+ Hits 4950 5596 +646
- Misses 269 284 +15
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for following this up :) Setting the first value and appending the rest is exactly what we want, since the internal requests go back through the same middleware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the net/http based adapters, a generated PATCH only keeps the last value of each header the PUT handler sets. For example, a PUT that returns two cookies:
PUT /things/t1sendsSet-Cookie: a=1andSet-Cookie: b=2, butPATCH /things/t1only sendsSet-Cookie: b=2. Withhuma.DefaultConfig, aLinkheader set by the handler is lost the same way, because thedescribedBylink that huma appends to the PUT response comes after it.The PATCH handler copies the headers of the internal PUT response with one
SetHeadercall per value (autopatch.go#L450-L454), so each value replaces the previous one. The copy for a failed GET does the same (#L321-L325). Both now go through a small helper that sets the first value of each header and appends the others.This came up in the review of #1130.