Repository navigation
Add undo for removing an action - #96
Merged
Merged
Conversation
Remove now leaves an undo bar under the actions list until the list changes again, and Delete removes the selected action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove in Settings deletes an action at once, with no confirmation and no way back. One stray click on the bin loses an action's name, icon, target, arguments, or script. The list also ignored the Delete key, which is the usual way to remove a selected list item on Windows.
Changes
Design notes
ActionsSettingsViewModelkeeps the removed action and its index. Any later collection change discards it, which keeps the saved index valid without tracking edits.Editor.Forget) is now dropped when the undo offer ends instead of at removal, so a restored Key action still follows key changes.InfoBarBorderStyleand sits above the drag caption, so nothing in the list moves when it appears.Before and after
Dark theme, captured from a harness that hosts the real
SettingsWindow.1. After removing Mute
2. After removing the last action (long name trims)