Repository navigation
Polish Settings copy, fonts, and hints - #95
Merged
Merged
Conversation
- Give the Settings window the 14px body size so the update banner's Download button stops inheriting the system message font size. - Lead the monospace stack with Consolas; WPF draws Cascadia Mono's regular weight heavy enough to read as bold in the script box. - Call the activation hotkey a hotkey in its own description, and cover the wording with a test. - Hide the Key field's Custom shortcut tip once Custom shortcut is selected. - Hide the drag caption under an empty actions list, where the empty state already says it. - Name Alt+Up and Alt+Down in the Move up and Move down tooltips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A screenshot review of every surface (Settings tabs and editor states in light and dark, the update banner, the minimum window size, and the pie at several sizes and slice counts) turned up six small inconsistencies in Settings:
Changes
SettingsWindowsetsFontSizetoBodyTextBlockFontSize, so anything outside a tab inherits the body size.MonospaceFontFamilyleads with Consolas, then Cascadia Mono, then Courier New.Before and after
Dark theme, captured from a harness that hosts the real
SettingsWindowwith Windows' default blue accent.1. Update banner
2. Script font
3. Hotkey description
4. Custom shortcut tip
5. Empty actions list
6. Move tooltips