Improve terminal output when uploading existing Zarr#1712
Improve terminal output when uploading existing Zarr#1712kabilar wants to merge 1 commit intodandi:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 84 84
Lines 11693 11693
=======================================
Hits 8749 8749
Misses 2944 2944
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
TWICE I tried to compose reply and then laptop was crashing due to too many displays etc... Friday it was !
this is incomplete display, i.e. process didn't finish -- how do you know that all was transferred? do you have access to the log? (path is printed at the end)
well -- 'zarr' is not a file per se. Could be a "fileset" or "catalog". We should unify naming. Which one you prefer? That "reuploading" part -- in principle it is consistent with how we would report for a regular blob asset if decide to reupload: see the end of that
I would need to comb the logic there... It is either the "done" from ❯ git grep -np '"done"' dandi/upload.py
dandi/upload.py=94=def upload(
dandi/upload.py:401: yield {"status": "done"}? needs analysis... |
|
changed to draft since still needs discussion etc |
I uploaded Zarr assets yesterday and the DANDI Hub terminated overnight, so I re-ran the upload this morning to make sure everything transferred. It turns out that all the data was already transferred but the terminal output was a bit confusing:
Specifically I would suggest the following changes:
exists - reuploadingshould be changed tofile exists. I have submitted the change here.doneshould be changed toskipped. I am not sure where the most appropriate place in thezarr.pymodule would be for the change to take place.