Add .nwb to known Zarr suffixes; add tests for NWB Zarr backend#1312
Add .nwb to known Zarr suffixes; add tests for NWB Zarr backend#1312CodyCBakerPhD wants to merge 7 commits intodandi:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
===========================================
- Coverage 88.51% 67.93% -20.58%
===========================================
Files 77 77
Lines 10492 10480 -12
===========================================
- Hits 9287 7120 -2167
- Misses 1205 3360 +2155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The current CI error TypeError: Can't instantiate abstract class NWBZarrIO with abstract method can_readhas a known cause and will likely need to await the upcoming release of |
|
@yarikoptic Trying the main branch (not this one) with Worth mentioning it began upload and proceeded find until 99% done when the error happened |
|
eh -- I spent some time trying to see smth in the logs
today
or if you retry again -- I might spot smth in the fresh dumps for heroku which I should be getting now. |
FWIW, in so we do not install development hdmf as well. Do you think we should? |
Inspired by #1312 and ongoing work for Zarr based backend for NWB.
|
I just tried again (from the save environment) and did not get the previous error Asset is now visible: https://gui-staging.dandiarchive.org/dandiset/204919/draft/files?location=test_read_nwbfile |
|
BTW the 'environment' I'm using right now is just the default/base on the DANDI Hub |
trying in #1320 and it leads to an error (posted there)
well, would need 1 more fresh .nwb.zarr I guess ;-) |
Inspired by #1312 and ongoing work for Zarr based backend for NWB.
yarikoptic
left a comment
There was a problem hiding this comment.
Let's make it more flexible and up to date
| **simple1_nwb_metadata, | ||
| ) | ||
| make_nwb_file( | ||
| tmp_path / "simple1_zarr.nwb", |
| filename: StrPath, | ||
| *args: Any, | ||
| cache_spec: bool = False, | ||
| backend: Literal["hdf5", "zarr"] = "hdf5", |
There was a problem hiding this comment.
Let's make it more explicit
| backend: Literal["hdf5", "zarr"] = "hdf5", | |
| backend: Literal["auto", "hdf5", "zarr"] = "auto", |
with "auto" choosing based on extension.
fix #1310
This seems to have worked fine for me on a local upload attempt to staging (validation had to be suppressed until we get NeurodataWithoutBorders/nwbinspector#388 and the integration follow-up through)
At least getting the seeds of this PR started