feat(react-chess-game): introduce typed game events and AudioManager for sound system#81
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 7a4efdb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dancamma
force-pushed
the
feat/audio-manager-refactor
branch
from
March 11, 2026 14:14
180ccf6 to
73549cc
Compare
The error sound was replaced with silence for illegal moves, but the test wasn't updated to reflect this change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dancamma
changed the title
The file was causing a lint error because it's not part of the TypeScript project but was being parsed by the TypeScript parser. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the sound system with a typed event architecture and centralized audio management:
Typed game events: New
ChessGameEventdiscriminated union with detailed event payloads (move-made,illegal-move,clock-timeout) including check/checkmate/draw state, move details, and timeout player infoAudioManager utility: Centralized audio handling with preloaded
HTMLAudioElementinstances for each sound type, proper cleanup viadestroy(), and graceful fallback for SSR/test environmentsSmart sound mapping: Maps game events to appropriate audio events with priority-based logic (checkmate → draw → promotion → castling → capture → check → move)
Bundled audio assets: Includes OGG sound files for capture, move, notify, timeout, and silence (for illegal moves)
Test plan
npm testpassesnpm run buildsucceeds🤖 Generated with Claude Code