fix(react-chess-game): sound and keyboard control improvements#80
Merged
Conversation
- Fix sound override merging (missing spread operator) - Add check sound support with proper priority (checkmate > capture > check > move) - Sounds only trigger on new moves, not on initial FEN load - Scope keyboard controls to focused board by default - Add containerRef option for custom keyboard scoping - Ignore keyboard shortcuts when focus is on input/textarea/select/contenteditable - Use ResizeObserver for responsive promotion menu positioning - Fix promotion menu positioning for black orientation - Fix deepMergeChessboardOptions using mergeWith instead of merge - Add extensive test coverage for all changes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 62b9a93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… board components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sounds.tsx)containerRefoption for custom keyboard scopingResizeObserverfor responsive promotion menu positioningdeepMergeChessboardOptionsusingmergeWithinstead ofmergeTest plan
🤖 Generated with Claude Code